fix[N10] Make better use of immutable #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
added
the
OZ Audit - March
mrice32
approved these changes
Mar 17, 2022
nicholaspai
approved these changes
Mar 17, 2022
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
LGTM but while you're at it, the following vars can also be made immutable:
Optimism_SpokePool
- l2Eth
SpokePool
- weth
Member
Author
good point! done. |
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Within the HubPool contract, the weth, finder, and lpTokenFactory variables are only ever assigned
a value in the constructor.
Solution:
made these variables that should never be changed immutable.