add executeExternalCall function #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
nicholaspai
reviewed
Oct 29, 2025
nicholaspai
reviewed
Oct 29, 2025
nicholaspai
reviewed
Oct 29, 2025
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
Left a question about delegatecall-ing self
fusmanii
reviewed
Oct 29, 2025
Contributor
fusmanii
left a comment
fusmanii
left a comment
There was a problem hiding this comment.
Looks good, one comment
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
changed the title
nicholaspai
previously approved these changes
Oct 30, 2025
fusmanii
previously approved these changes
Oct 30, 2025
grasphoper
previously approved these changes
Oct 30, 2025
fusmanii
added
the
need to audit
Signed-off-by: Ihor Farion <ihor@umaproject.org>
nicholaspai
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
onlyAdminfunctionexecuteExternaltoSpokePool. This function does an external call to the decoded target address.