fix: N03, event in executeExternalCall
#1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Farion <ihor@umaproject.org>
grasphoper
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
approved these changes
Nov 13, 2025
tbwebb22
added a commit
that referenced
this pull request
Nov 17, 2025
* add executeCustomActions function Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * clean up Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * remove nonreentrant modifier from executeCustomActions Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * add tests Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * comment Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * return data from custom action calls Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * remove delegatecall to self Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * rename function to executeExternalCall Signed-off-by: Taylor Webb <tbwebb22@gmail.com> * emit AdminExternalCallExecuted event (#1180) Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Taylor Webb <tbwebb22@gmail.com> Signed-off-by: Ihor Farion <ihor@umaproject.org> Co-authored-by: Ihor Farion <65650773+grasphoper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.