Skip to content

Conversation

@bmzig
Copy link
Contributor

@bmzig bmzig commented Nov 24, 2025

Across event emitter: https://monadvision.com/address/0xBF75133b48b0a42AB9374027902E83C5E2949034
Periphery: https://monadvision.com/address/0xe9b0666DFfC176Df6686726CB9aaC78fD83D20d7

Due to the upgrade to openzeppelin v5, the spoke pool periphery does not have the same bytecode as the other deployed ones. Do we want to deploy off the older bytecode to have them match? Setting as do not merge until that's resolved.

Signed-off-by: bennett <bennett@umaproject.org>
@bmzig bmzig added the do not merge do not merge label Nov 24, 2025
@bmzig bmzig changed the title feat: deploy spoke periphery and across event emitter to Monad chore: deploy spoke periphery and across event emitter to Monad Nov 24, 2025
@nicholaspai
Copy link
Member

Keeping the bytecode the same will keep the address the same, right? And that's a property we want AFAIK?

@bmzig
Copy link
Contributor Author

bmzig commented Nov 24, 2025

Keeping the bytecode the same will keep the address the same, right? And that's a property we want AFAIK?

I think the reasoning behind not keeping the same address here is that if we want to keep the same address then we need to reintroduce the openzeppelin v4 contracts and import them for the deterministic deployment contracts (as well as compile them at 0.8.23 instead of 0.8.30). The alternatives seem to either be to keep this address and redeploy the other peripheries to match the updated bytecode (or to keep this address different from the others until an update is warrented). Either way, unless we reintroduce the oz v4 contracts again and compile at 0.8.23 for some contracts, we are not going to get the same deployment addresses as what we have on other networks going forward.

Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
@bmzig bmzig removed the do not merge do not merge label Nov 25, 2025
@bmzig bmzig merged commit 769bd8d into master Nov 25, 2025
10 checks passed
@bmzig bmzig deleted the bz/monadExtras branch November 25, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants