Skip to content

Conversation

@chrismaree
Copy link
Member

Signed-off-by: chrismaree christopher.maree@gmail.com

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree chrismaree requested review from mrice32 and nicholaspai and removed request for mrice32 January 27, 2022 21:36
Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,14 @@
name: CI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file a dup from the other PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. it has a different name and runs a diffrent command.

the reason they are separate files it shows up as separate jobs.

I think you can merge them to achieve the same thing but it just seemed a bit cleaner to have separate files.

@chrismaree chrismaree merged commit ed775b4 into master Jan 27, 2022
@chrismaree chrismaree deleted the chrismaree/add-lint-ci branch January 27, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants