chore: Remove deprecated ERC-7683 v1 contracts#1402
Merged
Conversation
Remove contracts/erc7683/ (AcrossOriginSettler, ERC7683OrderDepositor, ERC7683Permit2Lib, ERC7683) and associated test. These were never deployed and are being superseded by a new version of ERC-7683. The minimal types still needed by SpokePool (IDestinationSettler, AcrossDestinationFillerData) are moved to contracts/interfaces/ERC7683.sol with deprecation comments. The SpokePool fill() function is also marked as deprecated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tbwebb22
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/erc7683/(AcrossOriginSettler, ERC7683OrderDepositor, ERC7683Permit2Lib, ERC7683) and theERC7683Permit2Lib.t.soltestIDestinationSettler,AcrossDestinationFillerData) are moved tocontracts/interfaces/ERC7683.solwith deprecation commentsfill()function NatSpec is marked as deprecatedTest plan
yarn build-evm-foundrycompiles cleanlyyarn test-evm-foundry— all 629 tests pass🤖 Generated with Claude Code