Skip to content

fix: Typo in HubPool about bond and final fee relationship #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: Typo in HubPool about bond and final fee relationship #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/HubPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ contract HubPool is HubPoolInterface, Testable, Lockable, MultiCaller, Ownable {
noActiveRequests
nonReentrant
{
// Bond should not be great than final fee otherwise every proposal will get cancelled in a dispute.
// Bond should not equal final fee otherwise every proposal will get cancelled in a dispute.
// In practice we expect that bond amounts are set >> final fees so this shouldn't be an inconvenience.
// The only way for the bond amount to be equal to the final fee is if the newBondAmount == 0.
require(newBondAmount != 0, "bond equal to final fee");
Expand Down