chore: add known issues md file#1425
Merged
Merged
Conversation
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
reviewed
May 8, 2026
| * | ||
| * @dev Any tokens left on this contract can be claimed by any caller. This is intentional — the handler is a | ||
| * stateless utility with no per-user accounting or admin rescue, and tokens delivered to it are expected to be | ||
| * consumed in the same transaction. Not a security issue; please do not report. |
Contributor
There was a problem hiding this comment.
Suggested change
| * consumed in the same transaction. Not a security issue; please do not report. | |
| * consumed in the same transaction. |
I would say we just want to state the contract behaviour and not warn people to not report
fusmanii
reviewed
May 8, 2026
| * | ||
| * @dev Any tokens left on this contract can be claimed by any caller. This is intentional — the proxy is a | ||
| * stateless utility with no per-user accounting or admin rescue, and tokens delivered to it are expected to be | ||
| * consumed in the same transaction. Not a security issue; please do not report. |
Contributor
There was a problem hiding this comment.
Suggested change
| * consumed in the same transaction. Not a security issue; please do not report. | |
| * consumed in the same transaction. | |
| * |
same here, wdyt?
grasphoper
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to just add these comments in the contracts rather than a new "known issues" file