fix: add haircut proposal #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
reviewed
May 19, 2022
contracts/HubPool.sol
Outdated
| function haircutReserves(address l1Token, int256 haircutAmount) public onlyOwner nonReentrant { | ||
| // Note that we do not call sync first in this method. The Owner should call this manually before haircutting. | ||
| // This is done in the event sync is reverting due to too low balanced in the contract relative to bond amount. | ||
| pooledTokens[l1Token].utilizedReserves += haircutAmount; |
Member
There was a problem hiding this comment.
What if owner sets this amount too high? Does it break the contract permanently?
mrice32
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.