Skip to content

Conversation

@mrice32
Copy link
Contributor

@mrice32 mrice32 commented Jul 29, 2022

This adapter is meant to rescue funds from a malfunctioning, broken, or misconfigured HubPool.

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
@mrice32 mrice32 requested review from kevinuma and nicholaspai July 29, 2022 19:09
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it can't be front run. This would require calling relayMessage multiple times from HubPool, so if you want to consolidate into one call you could hardcode all ERC20 token addresses to rescue. Could even pass them in via construction... but this contract is prob not over generalizaing and just building a one time, super simple hardcodedcontract

@mrice32
Copy link
Contributor Author

mrice32 commented Jul 29, 2022

This looks like it can't be front run. This would require calling relayMessage multiple times from HubPool, so if you want to consolidate into one call you could hardcode all ERC20 token addresses to rescue. Could even pass them in via construction... but this contract is prob not over generalizaing and just building a one time, super simple hardcodedcontract

Yeah, I wanted to keep it as simple as possible to keep it low risk.

@mrice32 mrice32 merged commit 875b02d into master Jul 29, 2022
@mrice32 mrice32 deleted the ethereum_rescue_adapter branch July 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants