improve(arbitrum-adapter): Use outboundTransferCustomRefund when sending tokens to L2 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinuma
approved these changes
Aug 11, 2022
mrice32
approved these changes
Aug 15, 2022
| if (l1Token == 0x6B175474E89094C44Da98b954EedeAC495271d0F) { | ||
| // Note: outboundTransfer() will ultimately create a retryable ticket and set this contract's address as the | ||
| // refund address. This means that the excess ETH to pay for the L2 transaction will be sent to the aliased | ||
| // contract address on L2 and lost. |
Contributor
There was a problem hiding this comment.
nit: we don't lose the ETH, it's just hard to retrieve (we have a custom adapter for retrieving it now).
| // Note: Legacy routers don't have the outboundTransferCustomRefund method, so default to using | ||
| // outboundTransfer(). Legacy routers are used for: | ||
| // - DAI | ||
| if (l1Token == 0x6B175474E89094C44Da98b954EedeAC495271d0F) { |
Contributor
There was a problem hiding this comment.
Is DAI the only token this applies to? Or just the only token we currently support that this applies to?
Member
Author
There was a problem hiding this comment.
The latter, DAI is the only token we currently support that this applies to, I'll clarify the comment
mrice32
approved these changes
Aug 15, 2022
| // Note: Legacy routers don't have the outboundTransferCustomRefund method, so default to using | ||
| // outboundTransfer(). Legacy routers are used for: | ||
| // - DAI | ||
| if (l1Token == 0x6B175474E89094C44Da98b954EedeAC495271d0F) { |
nicholaspai
deleted the
nick/acx-147-upgrade-arbitrum-adapter-to-set-custom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merged PR is now live for most Arbitrum ERC20 gateways (except DAI), so we can use the new function outboundTransferCustomRefund to receive refunds at an EOA we control instead of the aliased hub pool address, which is the L1 sender of the tokens technically.