-
Notifications
You must be signed in to change notification settings - Fork 75
feat: add merkle distributor contract #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add merkle distributor contract #185
Conversation
mrice32
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just two high level questions -- trying to understand how much of this is copied code vs freshly written.
| @@ -0,0 +1,257 @@ | |||
| // SPDX-License-Identifier: AGPL-3.0-only | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say "based on" do you mean directly copied? Or are there changes? If there are changes, we will likely need to have this re-audited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contract itself is identical
| @@ -0,0 +1,692 @@ | |||
| import { assert } from "chai"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here: is this copied code or should we review it? If copied, were there any specific changes we should look at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests structure is the same, only minor things were changed: replace web3 usage with ethers and update the assertion syntax (use expect instead of assert in order to have a similar syntax with the rest of the tests)
9b39990 to
a29e0e1
Compare
Signed-off-by: amatei <amatei@umaproject.org>
Signed-off-by: amatei <amatei@umaproject.org>
a29e0e1 to
6a68f0c
Compare
Socket Security ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 New install scripts detectedA dependency change in this PR is introducing new install scripts to your install step. 🫣 Native codeContains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.
Socket.dev scan summary
Powered by socket.dev |
This PRs adds the contract source code and tests for the Merkle Distributor contract. It is based on the already audited contract from the UMA protocol repository