feat(merkle-distributor): Make claim only callable by recipient or whitelisted claimer #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended use case is for `claim` to reset user's off-chain reward rate (used to produce rewards that would be seeded into this contract). Therefore, claim should only be callable by end recipient
nicholaspai
requested review from
amateima,
chrismaree,
kevinuma,
mrice32 and
pxrl
and removed request for
pxrl
Member
Author
|
Resolved this by storing list of whitelisted addresses |
nicholaspai
changed the title
nicholaspai
changed the title
chrismaree
reviewed
Nov 1, 2022
| // Note: uses a packed array of bools for gas optimization on tracking certain claims. Copied from Uniswap's contract. | ||
| mapping(uint256 => mapping(uint256 => uint256)) private claimedBitMap; | ||
|
|
||
| modifier onlyWhitelistedClaimer() { |
chrismaree
approved these changes
Nov 1, 2022
| require(claims[i].account == msg.sender, "invalid claimer"); | ||
| } | ||
| } | ||
| super.claimMulti(claims); |
Member
There was a problem hiding this comment.
assuming claimMulti and claim from within the MerkleDistributor works correctly, this wrapper contract looks perfect to me!
Member
Author
There was a problem hiding this comment.
yup and the tests give me confidence, which i didn't modify and should work against the parent's behavior
Co-authored-by: Chris Maree <christopher.maree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users shouldn't be able to claim on behalf of other users, but the AcceleratingDistributor should be able to in order to make
claimAndStakework