feat: Add claimFor method to AcrossMerkleDistributor #200
Conversation
Allows a whitelisted account to claim on behalf of a user. Can be used to atomically claim and perform some action for a user, such as claim and stake.
| require(whitelistedClaimers[msg.sender] || _claim.account == msg.sender, "invalid claimer"); | ||
| super.claim(_claim); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe this should be done in a separate PR, but it's a little confusing that whitelisted claimers can claim directly to their own address and call claimMulti to send tokens to the user.
If we end up going in this direction, do you think we should drop the overridden claimMulti and claim methods, just to reduce surface area and complexity?
There was a problem hiding this comment.
I think we still need to require that the claim.account is the caller so users can't reset each other's referral multipliers but i can remove the whitelist requirement. Thats more so to make testing easier but there's an easier way to do this
There was a problem hiding this comment.
Implemented the change where the whitelist only applies for claimFor: e21526a
There was a problem hiding this comment.
Good point, that makes sense!
| require(whitelistedClaimers[msg.sender] || _claim.account == msg.sender, "invalid claimer"); | ||
| super.claim(_claim); | ||
| } | ||
|
|
There was a problem hiding this comment.
Good point, that makes sense!
| require(claims[i].account == msg.sender, "invalid claimer"); | ||
| } | ||
| uint256 claimCount = claims.length; | ||
| for (uint256 i = 0; i < claimCount; i++) { |
There was a problem hiding this comment.
Undoes changes in https://github.com/across-protocol/contracts-v2/pull/195/files that allow a whitelisted claimer to claim on behalf of claimer
| * @param _claim leaf to claim. | ||
| */ | ||
|
|
||
| function claimFor(Claim memory _claim) public { |
There was a problem hiding this comment.
New claimFor method that whitelisted claimer can call
Allows a whitelisted account to claim on behalf of a user. Can be used to atomically claim and perform some action for a user, such as claim and stake.