feat: Add Arbitrum_RescueAdapter helper scripts #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid with future usage of this adapter
mrice32
reviewed
Dec 22, 2022
| bytes calldata data | ||
| ) external payable returns (uint256); | ||
|
|
||
| function createRetryableTicketNoRefundAliasRewrite( |
Contributor
There was a problem hiding this comment.
nit: should we use unsafeCreateRetryableTicket instead (I think the signature is the same)?
According to the current Inbox implementation on mainnet, createRetryableTicketNoRefundAliasRewrite is deprecated in favor of unsafeCreateRetryableTicket.
Member
Author
There was a problem hiding this comment.
This is a great call. createRetryableTicketNoRefundAliasRewrite calls unsafeCreateRetryableTicket so I agree we don't need to change deployed version
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid with future usage of this adapter