fix(Ethereum_SpokePool): Correct admin/owner comment #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
reviewed
Jan 4, 2023
nicholaspai
approved these changes
Jan 4, 2023
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
Great suggestion! I have one additional comment I'd like to see
This saves a post-deployment transaction to update the crossDomainAdmin. This does not change the ability to update the crossDomainAdmin in future; that is done via the HubPool both before and after this change.
nicholaspai
approved these changes
Jan 4, 2023
nicholaspai
reviewed
Jan 5, 2023
nicholaspai
approved these changes
Jan 5, 2023
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.