Skip to content

improve: Update speed up signature #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023
Merged

improve: Update speed up signature #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de06c83
improve: Update speed up signature
nicholaspai Jan 5, 2023
1ba930f
Update SpokePool.Fixture.ts
nicholaspai Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ abstract contract SpokePool is SpokePoolInterface, Testable, Lockable, MultiCall
// Note: we use encode instead of encodePacked because it is more secure, more in the "warning" section
// here: https://docs.soliditylang.org/en/v0.8.11/abi-spec.html#non-standard-packed-mode
bytes32 expectedDepositorMessageHash = keccak256(
abi.encode("ACROSS-V2-FEE-1.0", newRelayerFeePct, depositId, originChainId)
abi.encode("ACROSS-V2-FEE-2.0", newRelayerFeePct, depositId, originChainId)
);

// Check the hash corresponding to the https://eth.wiki/json-rpc/API#eth_sign[eth_sign]
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/SpokePool.Fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export async function modifyRelayHelper(
const messageHash = ethers.utils.keccak256(
defaultAbiCoder.encode(
["string", "uint64", "uint32", "uint32"],
["ACROSS-V2-FEE-1.0", modifiedRelayerFeePct, depositId, originChainId]
["ACROSS-V2-FEE-2.0", modifiedRelayerFeePct, depositId, originChainId]
)
);
const signature = await depositor.signMessage(ethers.utils.arrayify(messageHash));
Expand Down