Skip to content

improve: Default depositQuoteTimeBuffer=3600 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023
Merged

improve: Default depositQuoteTimeBuffer=3600 #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f765b9
improve: Default depositQuoteTimeBuffer=3600
nicholaspai Jan 25, 2023
41541f4
Update SpokePool.Deposit.ts
nicholaspai Jan 25, 2023
ad18aa3
Update SpokePool.Deposit.ts
nicholaspai Jan 25, 2023
addec79
Update SpokePool.Deposit.ts
nicholaspai Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ abstract contract SpokePool is SpokePoolInterface, Testable, Lockable, MultiCall
WETH9 public immutable wrappedNativeToken;

// Any deposit quote times greater than or less than this value to the current contract time is blocked. Forces
// caller to use an approximately "current" realized fee. Defaults to 10 minutes.
uint32 public depositQuoteTimeBuffer = 600;
// caller to use an approximately "current" realized fee. Defaults to 1 hour.
uint32 public depositQuoteTimeBuffer = 3600;

// Count of deposits is used to construct a unique deposit identifier for this spoke pool.
uint32 public numberOfDeposits;
Expand Down
4 changes: 2 additions & 2 deletions test/SpokePool.Deposit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ describe("SpokePool Depositor Logic", async function () {
amountToDeposit,
destinationChainId,
depositRelayerFeePct,
toBN(currentSpokePoolTime).add(toBN("700")) // > 10 mins in future
toBN(currentSpokePoolTime).add(toBN("3700")) // > 60 mins in future
)
)
).to.be.reverted;
Expand All @@ -239,7 +239,7 @@ describe("SpokePool Depositor Logic", async function () {
amountToDeposit,
destinationChainId,
depositRelayerFeePct,
toBN(currentSpokePoolTime).sub(toBN("700")) // > 10 mins in future
toBN(currentSpokePoolTime).sub(toBN("3700")) // > 60 mins in past
)
)
).to.be.reverted;
Expand Down
2 changes: 1 addition & 1 deletion test/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const repaymentChainId = 777;

export const firstDepositId = 0;

export const depositQuoteTimeBuffer = 10 * 60; // 10 minutes
export const depositQuoteTimeBuffer = 60 * 60; // 60 minutes

export const bondAmount = toWei("5");

Expand Down