chore: Import WETH9 #227
chore: Import WETH9 #227
Conversation
Make way a copy of the WETH9 implementation to be imported.
Import the full contract so that it can be tweaked and used as the base contract for the Across Bond Token (name subject to change). The import is made as-is, with no changes. Follow-up commits will apply modifications as required.
- Fix SPDX license identifier: AGPL-3.0-only => GPL-3.0-or-later
- Reinstate WETH9 license header for compliance with GPLv3 sections 4.
and 5:
https://www.gnu.org/licenses/gpl-3.0.html
- Relocate the pragma.
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Thanks for adding this! Some systems care about the name of the contract, not the name of the file. It's good cleanliness to name the file WETH9Interface.sol, but to make sure there's no conflicts in the hardhat artifacts or in other flattening procedures, we should change the name of the interface in the solidity WETH9 -> WETH9Interface.
Prompted by Matt.
Fair point - have renamed to WETH9 interface. What's your gut feel on this? Is it cleaner to just nuke the interface definition and use the newly imported version? I'm not sure either way. |
Done in advance of the new Across Bond Token (name tbc)
implementation, which will inherit from WETH9.
The reason for retaining the WETH9 interface description is that it's
less restrictive than the WETH9 contract that is being imported.
Specifically, Solidity is unhappy that the WETH9 contract identifies
payable functions, and that has ripple effects for the existing users
of the WETH9 interface. We might consider addressing those points,
but the focus here is just to shuffle the furniture to make space for
the new bond token.
Further changes to come once this is in.