feat: add succinct contracts #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
changed the title
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
nicholaspai
reviewed
Feb 16, 2023
| // private. Leaving it set to true can permanently disable admin calls. | ||
| bool private adminCallValidated; | ||
|
|
||
| uint16 public hubChainId; |
Member
There was a problem hiding this comment.
nit: can we make this a constant = 1 and temporarily override when deploying to goerli? Not a big deal but save some gas
Contributor
Author
There was a problem hiding this comment.
I don't think we can do that (unless we make it immutable) because it would be stored in the implementation contract and not the proxy, right?
nicholaspai
reviewed
Feb 16, 2023
contracts/Succinct_SpokePool.sol
Outdated
|
|
||
| // This operates similarly to a re-entrancy guard. It is set after validation to tell methods called by this | ||
| // method that the call has been validated as an admin and is safe. | ||
| require(!adminCallValidated, "Re-entered handleTelepathy"); |
Member
There was a problem hiding this comment.
Seems like a good candidate to use a modifier even though it adds contract storage and potentailly adds gas, it makes it more readable
nicholaspai
approved these changes
Feb 16, 2023
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
This is pretty straightforward to me LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the Succinct SpokePool and Adapter contracts. Note: succinct is only a message bridge, so the methods that relay tokens have been left as no-ops. Those will either need to be overridden, or be left as no-ops and never used on those chains (in favor of arbitrage-style mechanisms). Right now, I have these as no-ops rather than reverting so they don't prevent other related actions from going through. Might be a good idea to have them emit a warning event that we can watch for.
Note: I used the succinct contracts in this repo: https://github.com/succinctlabs/telepathy-contracts.