Skip to content

Added selector return to handleTelepathy #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Added selector return to handleTelepathy #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5323073
Added selector return to handleTelepathy
puma314 Feb 17, 2023
030e92b
Added back newline
puma314 Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/Succinct_SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ contract Succinct_SpokePool is SpokePool, ITelepathyHandler {
uint16 _sourceChainId,
address _senderAddress,
bytes memory _data
) external override validateInternalCalls {
) external override validateInternalCalls returns (bytes4) {
// Validate msg.sender as succinct, the x-chain sender as being the hubPool (the admin) and the source chain as
// 1 (mainnet).
require(
Expand All @@ -70,6 +70,7 @@ contract Succinct_SpokePool is SpokePool, ITelepathyHandler {
/// @custom:oz-upgrades-unsafe-allow delegatecall
(bool success, ) = address(this).delegatecall(_data);
require(success, "delegatecall failed");
return ITelepathyHandler.handleTelepathy.selector;
}

function _bridgeTokensToHubPool(RelayerRefundLeaf memory) internal override {
Expand Down