improve(SpokePool): Remove Testable/Timer base contract #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This base contract adds unneccessary gas costs to `getCurrentTime` calls and `setCurrentTime` is never used in production. This PR replaces those base contracts with a `getCurrentTime` implementation directly in the `SpokePool` contract. Tests then use `MockSpokePool` which extends the `getCurrentTime` functionality and also adds a `setCurrentTime` call
pxrl
approved these changes
Feb 18, 2023
Contributor
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
Nice to clean this up. Not sure about the change to deployments.json, but otherwise LGTM 👍
| { | ||
| "1": { | ||
| "AcrossConfigStore": { "address": "0x3B03509645713718B78951126E0A6de6f10043f5", "blockNumber": 14717196 }, | ||
| "AcrossMerkleDistributor": { "address": "0xE50b2cEAC4f60E840Ae513924033E753e2366487", "blockNumber": 15976846 }, |
Contributor
There was a problem hiding this comment.
Could this be an unintentional change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This base contract adds unneccessary gas costs to
getCurrentTimecalls andsetCurrentTimeis never used in production. This PR replaces those base contracts with agetCurrentTimeimplementation directly in theSpokePoolcontract.Tests then use
MockSpokePoolwhich extends thegetCurrentTimefunctionality and also adds asetCurrentTimecall