feat: add message to across #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
changed the title
nicholaspai
reviewed
Feb 20, 2023
| import "@openzeppelin/contracts/utils/math/SignedMath.sol"; | ||
| import "@openzeppelin/contracts/utils/Address.sol"; | ||
|
|
||
| interface AcrossMessageHandler { |
Member
There was a problem hiding this comment.
nit add comment here about whats expected of integrators before mergimg
nicholaspai
reviewed
Feb 20, 2023
| abi.encode( | ||
| keccak256("UpdateRelayerFeeMessage(int64 newRelayerFeePct,uint32 depositId,uint256 originChainId)"), | ||
| newRelayerFeePct, | ||
| UPDATE_DEPOSIT_DETAILS_HASH, |
nicholaspai
reviewed
Feb 20, 2023
| require(isValid, "invalid signature"); | ||
| } | ||
|
|
||
| function _verifySlowFill( |
Member
There was a problem hiding this comment.
Moving it here just for readability?
Contributor
Author
There was a problem hiding this comment.
Yep. Just to make the flow super simple and similar in each of the fill methods -- check some single-line requirements and then process the fill.
nicholaspai
reviewed
Feb 20, 2023
| } | ||
|
|
||
| if (Address.isContract(relayData.recipient) && relayData.message.length > 0) { | ||
| AcrossMessageHandler(relayData.recipient).handleAcrossMessage( |
Member
There was a problem hiding this comment.
So if this fails, then relay is not filled at all and depositor can update the recipient/data, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.