Skip to content

Conversation

@nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Feb 22, 2023

We use the viaIR compiler flag so we don't need these brackets. This internal function is run on every fillRelay call

We use the `viaIR` compiler flag so we don't need these brackets
@nicholaspai nicholaspai marked this pull request as ready for review February 22, 2023 20:57
@nicholaspai nicholaspai requested review from mrice32 and pxrl February 22, 2023 20:57
Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

payoutAdjustmentPct: relayExecution.payoutAdjustmentPct
});
}
RelayExecutionInfo memory relayExecutionInfo = RelayExecutionInfo({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call -- I figured these would be necessary even with viaIR, but I was wrong!

@nicholaspai nicholaspai merged commit d1fa454 into master Feb 23, 2023
@nicholaspai nicholaspai deleted the npai/stack-too-deep branch February 23, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants