improve: Allow filled amount to be 0 to empower slow relayers #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrice32
approved these changes
Feb 8, 2022
|
|
||
| // Adding brackets "stack too deep" solidity error. | ||
| { | ||
| if (maxTokensToSend > 0) { |
Contributor
There was a problem hiding this comment.
Can you think of anywhere that we use the filledAmount stored in the contract as a proxy for the relay being "initialized"? If so, this relay would still be considered uninitialized. I can't think of anywhere this would cause problems, just wanted to ask in case you could.
Member
Author
There was a problem hiding this comment.
We don't, there isn't really a good way of checking whether a relay was initialized at the moment. For that we'd need to expand the data associated with each relay hash
chrismaree
approved these changes
Feb 8, 2022
pxrl
pushed a commit
that referenced
this pull request
Feb 8, 2024
…nt (#25) chainId is not useful because it is known based on the SpokePool being queried. Also, the marginal value of indexing the leafId on top of the rootBundleId is pretty minimal, so instead index fillsRefundedRoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.