improve: [L02] Lack of event emission after sensitive action #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## From Audit: The `setSuccinctTargetAmb` administrative function does not emit a relevant event after changing the `succinctTargetAmb` address. Consider always emitting events after sensitive changes take place to facilitate tracking and notify off-chain clients that follow the protocol's contracts' activity. ## Developer response This PR not only addresses the above issue but adds events to the `Polygon_SpokePool` and `Succinct_SpokePool`'s handler functions that trigger when they are called by an L2 system contract to finalize an L1-->L2 message
nicholaspai
added
the
OZ Audit - March 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Audit:
The
setSuccinctTargetAmbadministrative function does not emit a relevant event after changing thesuccinctTargetAmbaddress.Consider always emitting events after sensitive changes take place to facilitate tracking and notify off-chain clients that follow the protocol's contracts' activity.
Developer response
This PR not only addresses the above issue but adds events to the
Polygon_SpokePoolandSuccinct_SpokePool's handler functions that trigger when they are called by an L2 system contract to finalize an L1-->L2 message