improve: [N04] Typographical errors #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## From Audit Consider correcting the following typographical errors: In BondToken.sol : Line 11, "rootBundleProposer()" should be "rootBundleProposal()". Line 21: "permissiong" should be "permissioning". In EIP712CrossChainUpgradeable.sol : Line 83: "its always" should be "it's always". In MultiCallerUpgradeable.sol : Line 5: "@title MockSpokePool" should be "@title MultiCallerUpgradeable". In Optimism_Adapter.sol : Line 23: "its only" should be "it's only". In Polygon_SpokePool.sol : Line 51: the sentence "See" is incomplete. Line 139: the sentence is malformed. In SpokePool.sol : Line 567: "speedUpRelay()" should be "speedUpDeposit()". Line 1177: "its always" should be "it's always". In Succinct_Adapter.sol : Line 27: "destinatipn" should be "destination". Line 27: "the message.." should be "the message.". In Succinct_SpokePool.sol : Line 22: "callValidated" should be "adminCallValidated". Line 24: "callValidated" should be "adminCallValidated". Line 35: "callValidated" should be "adminCallValidated".
nicholaspai
added
the
OZ Audit - March 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Audit
Consider correcting the following typographical errors:
In BondToken.sol :
Line 11, "rootBundleProposer()" should be "rootBundleProposal()".
Line 21: "permissiong" should be "permissioning".
In EIP712CrossChainUpgradeable.sol :
Line 83: "its always" should be "it's always".
In MultiCallerUpgradeable.sol :
Line 5: "@title MockSpokePool" should be "@title MultiCallerUpgradeable".
In Optimism_Adapter.sol :
Line 23: "its only" should be "it's only".
In Polygon_SpokePool.sol :
Line 51: the sentence "See" is incomplete.
Line 139: the sentence is malformed.
In SpokePool.sol :
Line 567: "speedUpRelay()" should be "speedUpDeposit()".
Line 1177: "its always" should be "it's always".
In Succinct_Adapter.sol :
Line 27: "destinatipn" should be "destination".
Line 27: "the message.." should be "the message.".
In Succinct_SpokePool.sol :
Line 22: "callValidated" should be "adminCallValidated".
Line 24: "callValidated" should be "adminCallValidated".
Line 35: "callValidated" should be "adminCallValidated".