improve: [N06] Unused imports #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## From Audit The Across Protocol V2 codebase contains the interfaces directory, but the HubPoolInterface.sol and SpokePoolInterface.sol files do not reside in that location. Instead, they are located in the parent directory. Consider moving all non-external interface files to the interfaces directory, so that interfaces can be more easily located. ## Developer's response I appreciate this push as I've always found it inconsistent to have `interface` files not in `interface/` folders. I've added `interface` folders to each main contract directory
## From Audit The following imports are unused: Import AdapterInterface.sol in HubPoolInterface.sol Import ECDSA.sol in SpokePool.sol To improve readability and avoid confusion, consider removing any unused imports.
nicholaspai
added
the
OZ Audit - March 2023
mrice32
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Audit
The following imports are unused:
Import AdapterInterface.sol in HubPoolInterface.sol
Import ECDSA.sol in SpokePool.sol
To improve readability and avoid confusion, consider removing any unused imports.