improve(SpokePool): Apply rounding consistently to partial and full fills #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ills Currently the `amountToSend` could have rounding errors based on the division in `_computeAmountPreFees` and `_computeAmountPostFees`. The rounding errors are applied differently for partial fills and full fills, the latter of which only applies the preFees computation, while the former applies both preFees and postFees. This PR enforces consistently both the preFees and postFees computations to `amountToSend`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounding errors are possible when computing
fillAmountPreFeesand we want to enforce that the error is considered inamountToSendboth to partial and full fills. CurrentlyamountToSendis only reset to its postFee amount for situations wheremaxTokensToSend > amountRemainingInRelaywhich is often the case for slow fills. We should apply the error consistently regardless of the type of fill.