fix: Execute fill with updated message and recipient #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sped up, updated message and recipient are not used
Comment on lines
+1226
to
1240
| _unwrapwrappedNativeTokenTo(payable(relayExecution.updatedRecipient), amountToSend); | ||
| // Else, this is a normal ERC20 token. Send to recipient. | ||
| } else { | ||
| // Note: Similar to note above, send token directly from the contract to the user in the slow relay case. | ||
| if (!relayExecution.slowFill) | ||
| IERC20Upgradeable(relayData.destinationToken).safeTransferFrom( | ||
| msg.sender, | ||
| relayData.recipient, | ||
| relayExecution.updatedRecipient, | ||
| amountToSend | ||
| ); | ||
| else | ||
| IERC20Upgradeable(relayData.destinationToken).safeTransfer( | ||
| relayExecution.updatedRecipient, | ||
| amountToSend | ||
| ); |
Contributor
There was a problem hiding this comment.
Nit: should we add the tsconfig setting to require brackets after conditionals?
Member
Author
There was a problem hiding this comment.
do you know which config we should set for that? I marginally favor requiring brackets but not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sped up, updated message and recipient are not used