improve(SpokePool): Pass fillCompleted and relayer to acrossMessageHandler #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndler Signed-off-by: nicholaspai <npai.nyc@gmail.com>
mrice32
reviewed
Apr 24, 2023
| AcrossMessageHandler(relayExecution.updatedRecipient).handleAcrossMessage( | ||
| relayData.destinationToken, | ||
| amountToSend, | ||
| relayFills[relayExecution.relayHash] >= relayData.amount, |
Contributor
There was a problem hiding this comment.
Should this be the opposite? Wouldn't the stored fill amount be >= (really just ==, but >= just to be safe) the total fill amount when it's completely filled? Or am I missing something?
relayData.amount <= relayFills[relayExecution.relayHash].
Member
Author
There was a problem hiding this comment.
isn't the above equation exactly what I have in the PR?
Contributor
There was a problem hiding this comment.
Sorry, yeah, the direction of the inequality just got twisted in my head. You're right!
mrice32
approved these changes
Apr 24, 2023
pxrl
reviewed
Apr 24, 2023
pxrl
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow recipient to handle cases where a deposit with a message is sent in multiple partial fills, by different relayers.
Y
Signed-off-by: nicholaspai npai.nyc@gmail.com