chore: Bump minimum nodejs version #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also note at some point before the end of this year, we will need to get off nodejs 16.x. I tried this locally, but we have local copies of hardhat 2.9.x that anchor us to nodejs 16. So we'll need to resolve that. |
james-a-morris
approved these changes
Jun 6, 2023
Contributor
james-a-morris
left a comment
james-a-morris
left a comment
There was a problem hiding this comment.
In it's current state, this looks good to me
| }, | ||
| "engines": { | ||
| "node": ">=12" | ||
| "node": ">=16.18.0" |
Contributor
There was a problem hiding this comment.
Should we leave TS to choose it's most recent version of node? i.e. "node": ">= 16.0.0"
Contributor
Author
There was a problem hiding this comment.
Will follow up on this one async 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.