Create PermissionSplitter #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
Contributor
james-a-morris
left a comment
james-a-morris
left a comment
There was a problem hiding this comment.
Left a few comments related to documentation and a small nit. LGTM
Comment on lines
+24
to
+25
| // Public function! | ||
| // Note: these have two underscores in front to prevent any collisions with the target contract. |
Contributor
There was a problem hiding this comment.
Do we want to be following the natspec for this?
It may be beneficial to include these doc comments (/** .. */ or ///) for better IDE support / readability
Comment on lines
+31
to
+32
| // Public function! | ||
| // Note: these have two underscores in front to prevent any collisions with the target contract. |
|
|
||
| function _isAllowedToCall(address caller, bytes calldata callData) internal view virtual returns (bool) { | ||
| bytes4 selector; | ||
| if (callData.length < 4) { |
Contributor
There was a problem hiding this comment.
Nit: would we want to store this in a constant? The 4 seems like a magic number
mrice32
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contract is a proxy that owns another contract and can split permissions by role based on what method is being called. All methods are always callable by the owner of the proxy.