feat(spoke-pool): Reduce size of state variables #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismaree
reviewed
Feb 14, 2022
contracts/Optimism_SpokePool.sol
Outdated
| uint64 _depositQuoteTimeBuffer, | ||
| address timerAddress | ||
| address timerAddress, | ||
| uint32 _depositQuoteTimeBuffer |
Member
There was a problem hiding this comment.
should we default this to what we use in prod (10 mins) then remove it from the constructor? this is what I did in the hub pool: as much as posible remove the instantiation of constructor variables if we know what they will be in production. thoughts?
mrice32
approved these changes
Feb 15, 2022
Comment on lines
45
to
52
| uint32 public deploymentTime; | ||
|
|
||
| // Any deposit quote times greater than or less than this value to the current contract time is blocked. Forces | ||
| // caller to use an up to date realized fee. | ||
| uint64 public depositQuoteTimeBuffer; | ||
| // caller to use an up to date realized fee. Defaults to 10 minutes. | ||
| uint32 public depositQuoteTimeBuffer = 600; | ||
|
|
||
| // Use count of deposits as unique deposit identifier. | ||
| uint64 public numberOfDeposits; | ||
| uint32 public numberOfDeposits; |
Contributor
There was a problem hiding this comment.
nit: can we move these down below weth, since I assume weth and all of these will be read on each deposit, so we'll end up saving one word's worth a reads by grouping them.
pxrl
added a commit
that referenced
this pull request
Feb 20, 2024
This PR is cherry-picked directly from contracts-v2/master. Originally authored by Nick & Matt. Signed-off-by: nicholaspai <npai.nyc@gmail.com> Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percentages and timestamp-based variables can be smaller size to save gas costs for storing data