feat: add base deployments #339
Conversation
| @@ -0,0 +1,31 @@ | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
There was a problem hiding this comment.
This is an exact copy of Optimism_SpokePool.sol, only the name has been changed.
| @@ -0,0 +1,83 @@ | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
There was a problem hiding this comment.
This is an exact copy of the Boba_Adapter. Only the name has been changed.
| @@ -0,0 +1,28 @@ | |||
| import { ethers } from "ethers"; | |||
There was a problem hiding this comment.
This is a lightly modified version of the Optimism adapter deployment script.
| @@ -0,0 +1,17 @@ | |||
| import { deployNewProxy } from "../utils/utils.hre"; | |||
There was a problem hiding this comment.
Lightly modified Optimism spoke pool deployment script.
| @@ -0,0 +1,1620 @@ | |||
| { | |||
There was a problem hiding this comment.
This wasn't generated for some reason during deployment (I think the proxies don't generate these files for some reason), so i just copied the optimism auto-generated file. No need to review this.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "address": "0x4D9079Bb4165aeb4084c526a32695dCfd2F77381", | |||
| "address": "0x5c7BCd6E7De5423a257D81B442095A1a6ced35C5", | |||
There was a problem hiding this comment.
Updated this address because it was outdated, and wanted to make sure that we didn't accidentally interact with the outdated address.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "address": "0xa420b2d1c0841415A695b81E5B867BCD07Dff8C9", | |||
| "address": "0x6f26Bf09B1C792e3228e5467807a900A503c0281", | |||
There was a problem hiding this comment.
Same, updated this so we don't accidentally send transactions to the old address.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "address": "0x69B5c72837769eF1e7C164Abc6515DcFf217F920", | |||
| "address": "0x9295ee1d8C5b022Be115A2AD3c30C72E34e7F096", | |||
There was a problem hiding this comment.
Same, updated this so we don't accidentally send transactions to the old address.
utils/utils.hre.ts
Outdated
|
|
||
| const proxy = await upgrades.deployProxy(await getContractFactory(name, {}), args, { | ||
| kind: "uups", | ||
| unsafeAllow: ["delegatecall"], |
There was a problem hiding this comment.
I wasn't able to deploy without this, so I left it in. @nicholaspai is there somewhere else this should be specified or is this correct?
There was a problem hiding this comment.
FWIW I hit the same issue on zkSync. It seems like we are importing AddressUpgradeable.sol via Initializable.sol. @nicholaspai found that the import was recently removed, so it's no longer there on master. Hopefully we can remove this suppression after updating the dependency.
There was a problem hiding this comment.
Yeah it depends on a new OZ NPM package unfortunately
| "contracts/HubPool.sol": LARGE_CONTRACT_COMPILER_SETTINGS, | ||
| "contracts/Boba_SpokePool.sol": LARGE_CONTRACT_COMPILER_SETTINGS, | ||
| "contracts/Optimism_SpokePool.sol": LARGE_CONTRACT_COMPILER_SETTINGS, | ||
| "contracts/Base_SpokePool.sol": LARGE_CONTRACT_COMPILER_SETTINGS, |
There was a problem hiding this comment.
Added a few bits of config to the hh config in order to support base and its contracts.
This PR introduces a few various changes to support base:
Unrelated to Base, this PR also updates the outdated SpokePool addresses in the deployments folder. Many of these were still pointing to the old SpokePool addresses from a few months ago.