refactor: Split out and improve SpokePool deposit tests #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many now, so it makes sense to split them apart before adding new ones. While here: - Enforce that deposits revert for the expected revert reasons. - Enforce that deposits succeed and emit a "FundsDeposited" event. - Tweak a utility function for simplicity. Done in advance of a proposed change to the SpokePool quoteTimestamp validation.
james-a-morris
approved these changes
Sep 14, 2023
Contributor
james-a-morris
left a comment
james-a-morris
left a comment
There was a problem hiding this comment.
This looks like a straightforward refactor
| await spokePool.setEnableRoute( | ||
| route.originToken, | ||
| route.destinationChainId ? route.destinationChainId : consts.destinationChainId, | ||
| route.enabled !== undefined ? route.enabled : true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many now, so it makes sense to split them apart before adding new ones. While here:
Done in advance of a proposed change to the SpokePool quoteTimestamp validation.