feat: deposit() wrapper with current quoteTimestamp #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depositNow() is a new deposit() wrapper that removes the need for the caller to supply a quoteTimestamp. Instead, the value of getCurrentTime() is used. This is introduced to address the issue of multisig depositors having only a narrow window to collect the necessary signatures for a deposit. Instead, LP fee certainty is traded for flexibility around when the deposit is able to be submitted. The depositor is still able to query the expected LP fee via the Across API, so the chance of paying more fees than anticipated is fairly low.
ACX-1544 contracts: deposit() wrapper that uses current time for quoteTimestamp
Discussed during the Monday Across sync. This makes it easier for multisig signers to successfully deposit, without a sharp time constraint between generating the deposit and submitting it. It's low priority, but also a simple change to make in the contracts. |
nicholaspai
reviewed
Sep 19, 2023
| bytes memory message, | ||
| uint256 maxCount | ||
| ) public payable { | ||
| deposit( |
Member
There was a problem hiding this comment.
I think you'll need to pass through the msg.value to deposit
Contributor
Author
There was a problem hiding this comment.
msg.value propagates because the call to deposit() is internal, but I've added tests to verify this: 9499d4e.
nicholaspai
reviewed
Sep 19, 2023
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
Looks good but one change required I think https://github.com/across-protocol/contracts-v2/pull/357/files#r1330205507
nicholaspai
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depositNow() is a new deposit() wrapper that removes the need for the caller to supply a quoteTimestamp. Instead, the value of getCurrentTime() is used.
This is introduced to address the issue of multisig depositors having only a narrow window to collect the necessary signatures for a deposit. Instead, LP fee certainty is traded for flexibility around when the deposit is able to be submitted. The depositor is still able to query the expected LP fee via the Across API, so the chance of paying more fees than anticipated is fairly low.
Ref ACX-1544