Ethereum Spoke Pool #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrismaree
commented
Feb 16, 2022
chrismaree
commented
- Update hub for protocol fees
- nit
- Update test/chain-adapters/Arbitrum_Adapter.ts
- Update test/chain-adapters/Arbitrum_Adapter.ts
- nit
- nit
- WIP
- WIP
- nit
- WIP
- nit
- nit
- nit
- feat: add L1 SpokePool
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
nicholaspai
reviewed
Feb 16, 2022
contracts/Ethereum_SpokePool.sol
Outdated
| /** | ||
| * @notice Changes the L1 contract that can trigger admin functions on this contract. | ||
| * @dev This should be set to the address of the L1 contract that ultimately relays a cross-domain message, which | ||
| * is expected to be the Optimism_Adapter. |
Member
There was a problem hiding this comment.
Need to change or remove these comments
nicholaspai
approved these changes
Feb 16, 2022
mrice32
approved these changes
Feb 16, 2022
| * @dev Used on Ethereum L1 to facilitate L2->L1 transfers. | ||
| */ | ||
|
|
||
| contract Ethereum_SpokePool is SpokePoolInterface, SpokePool, Ownable { |
Contributor
There was a problem hiding this comment.
As discussed IRL, we might want to add a TODO to refactor the SpokePool inheritance setup s.t. we can have most of these methods implemented in the base contract and just have an _calledByAdmin() function that's implemented in each derived class, and have the base class call require(_calledByAdmin(), "not authorized");
pxrl
pushed a commit
that referenced
this pull request
Feb 26, 2024
…Proxy, contracts in production (#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.