Skip to content

feat(deployment): Deploy SpokePoolVerifier via create2 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat(deployment): Deploy SpokePoolVerifier via create2 #362

merged 2 commits into from
Oct 5, 2023

Conversation

@nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Oct 4, 2023 •
edited
Loading

Fixes ACX1503

However, doesn't include ZkSync yet

@nicholaspai nicholaspai marked this pull request as ready for review October 4, 2023 19:54
@nicholaspai nicholaspai requested review from mrice32 and pxrl October 4, 2023 19:54
mrice32
mrice32 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicholaspai nicholaspai merged commit 99f904a into master Oct 5, 2023
@nicholaspai nicholaspai deleted the npai/spoke-pool-verifier-deploy branch October 5, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrice32 mrice32 mrice32 approved these changes

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicholaspai @mrice32