refactor: Simplify Deposit test + helpers #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify deposit generation by converting getDepositParams() to accept an object, rather than a fixed list of parameters. This makes it cleaner for the caller to opt-out of supplying various inputs. This was prompted by a need to update the deposit() and getDepositParams() utilities such that the caller can supply a custom message.
pxrl
commented
Oct 13, 2023
pxrl
commented
Oct 13, 2023
pxrl
commented
Oct 13, 2023
pxrl
commented
Oct 13, 2023
nicholaspai
approved these changes
Oct 13, 2023
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
LGTM thanks for doing this. We had a TODO in the recent clean up to copy these utilities to the relayer repo. Should we do it now?
Contributor
Author
It's not clear to me whether it's better to copy, or just invest effort in fixing the utils here. If we copied then it'd probably have to go to sdk-v2, since we also depend on the functionality there. I'm just not a big fan of having duplicates of these utilities. |
This reverts commit 357ef7d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify deposit generation by converting getDepositParams() to accept an object, rather than a fixed list of parameters. This makes it cleaner for the caller to opt-out of supplying various inputs.
This was prompted by a need to update the deposit() and getDepositParams() utilities such that the caller can supply a custom message.