feat(contracts): Add initial LP functionality #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
nicholaspai
approved these changes
Jan 24, 2022
nicholaspai
reviewed
Jan 24, 2022
| }, | ||
| "dependencies": {}, | ||
| "dependencies": { | ||
| "@openzeppelin/contracts": "^4.4.2", |
There was a problem hiding this comment.
why shouldn't these be dev dependencies?
There was a problem hiding this comment.
I made them normal dependencies because that's what we do in the V1 repo: https://github.com/across-protocol/across-smart-contracts/blob/master/package.json
nicholaspai
approved these changes
Jan 24, 2022
mrice32
added a commit
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Signed-off-by: bennett <bennett@umaproject.org> Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
added a commit
that referenced
this pull request
Feb 3, 2025
* chore: formatting fix (#1) Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * Arbitrum, Ink, Mode, ZkSync * chore: Deploy Blast SpokePool implementation (#3) * chore: Deploy AlephZero SpokePool implementation (#6) * chore: Deploy WorldChain SpokePool implementation (#5) * deploy base lisk eth redstone scroll soneium spoke implementations (#4) Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Signed-off-by: bennett <bennett@umaproject.org> Co-authored-by: Matt Rice <matthewcrice32@gmail.com> * chore: add deployments for linea, optimism, polygon, and zora (#7) Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix(test): Require transfer to msg.sender on fill (#8) * fix(artifacts): update artifacts with implementation address Signed-off-by: bennett <bennett@umaproject.org> --------- Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Signed-off-by: bennett <bennett@umaproject.org> Co-authored-by: nicholaspai <npai.nyc@gmail.com> Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com> Co-authored-by: bmzig <57361391+bmzig@users.noreply.github.com> Co-authored-by: bennett <bennett@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chrismaree christopher.maree@gmail.com