Skip to content

fix: add bug fix and updated deployment artifacts #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 3, 2025
Merged

fix: add bug fix and updated deployment artifacts #880

merged 10 commits into from
Feb 3, 2025

Conversation

@mrice32
Copy link
Contributor

@mrice32 mrice32 commented Feb 3, 2025 •
edited
Loading

More details are coming later this week, but a bug was reported to the Across team.

The fix and deployments in this PR were used to resolve the bug. This PR is simply to publish those changes to our public repository now that the vulnerability has been resolved.

Note: the bug and fix has been verified by our auditors, OpenZeppelin.

mrice32 and others added 9 commits January 28, 2025 17:14
@mrice32
chore: formatting fix (#1)
c202f34 
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
@nicholaspai
Arbitrum, Ink, Mode, ZkSync
a0addf7
@pxrl
chore: Deploy Blast SpokePool implementation (#3)
cc08432
@pxrl
chore: Deploy AlephZero SpokePool implementation (#6)
da9444a
@pxrl
chore: Deploy WorldChain SpokePool implementation (#5)
8582f1a
@bmzig @mrice32
deploy base lisk eth redstone scroll soneium spoke implementations (#4)
3dd52ea 
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Signed-off-by: bennett <bennett@umaproject.org>
Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
@mrice32
chore: add deployments for linea, optimism, polygon, and zora (#7)
0b6e930 
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
@pxrl
fix(test): Require transfer to msg.sender on fill (#8)
8014c21
@bmzig
fix(artifacts): update artifacts with implementation address
19bd649 
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
nicholaspai previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to rebase this off master to reduce the diff. I'm surprised some of the changes in hardhat.config.ts are not already in master for example

@mrice32
Copy link
Contributor Author

mrice32 commented Feb 3, 2025

You might need to rebase this off master to reduce the diff. I'm surprised some of the changes in hardhat.config.ts are not already in master for example

Yeah, working on it.

@mrice32
Copy link
Contributor Author

mrice32 commented Feb 3, 2025

You might need to rebase this off master to reduce the diff. I'm surprised some of the changes in hardhat.config.ts are not already in master for example

should be good now.

@mrice32 mrice32 requested a review from nicholaspai February 3, 2025 21:12
@mrice32 mrice32 merged commit 110e3fd into master Feb 3, 2025
9 checks passed
@mrice32 mrice32 deleted the mrice32/artifacts branch February 3, 2025 23:20
@md0x md0x mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@bmzig bmzig bmzig approved these changes

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrice32 @nicholaspai @bmzig @pxrl