improve: rename merkle root related variables and function names #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
commented
Feb 17, 2022
| ); | ||
| ancillaryData = AncillaryData.appendKeyValueBytes32( | ||
| ancillaryData, | ||
| "slowRelayFulfillmentRoot", |
Member
Author
There was a problem hiding this comment.
We didn't have this slow relay root in the ancillary data before
nicholaspai
commented
Feb 17, 2022
| function setEnableRoute( | ||
| address originToken, | ||
| uint32 destinationChainId, | ||
| uint256 destinationChainId, |
Member
Author
There was a problem hiding this comment.
this should match the types of the other spoke pool interfaces
chrismaree
reviewed
Feb 18, 2022
| uint64 unclaimedPoolRebalanceLeafCount; | ||
| bytes32 poolRebalanceRoot; | ||
| bytes32 destinationDistributionRoot; | ||
| bytes32 relayerRefundRoot; |
chrismaree
approved these changes
Feb 18, 2022
pxrl
added a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Co-authored-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.