feat: Snapshot latest deployed storage layouts #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload latest deployed storage layouts for comparison with potential new contracts
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
Upload latest deployed storage layouts for comparison with potential new contracts
…ocol/contracts-v2 into npai/storage-layouts
…rotocol/contracts-v2 into mrice32/minimal_foundry
mrice32
approved these changes
Jan 7, 2024
Contributor
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Should we add the tool to regenerate these on demand?
nicholaspai
changed the title
pxrl
pushed a commit
that referenced
this pull request
Feb 20, 2024
* WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * feat: Snapshot deployed storage layouts Upload latest deployed storage layouts for comparison with potential new contracts * Add latest storage layouts * Update foundry.toml * Update foundry.toml * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * feat: Snapshot deployed storage layouts Upload latest deployed storage layouts for comparison with potential new contracts * Add latest storage layouts * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * Update foundry.toml * Update foundry.toml * Add latest deployed snapshots and script to snapshot * Update .gitignore --------- Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: Matt Rice <matthewcrice32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload latest deployed storage layouts for comparison with potential new contracts
Other potential tools we could use as an alternative to forge are listed here FYI: https://proxies.yacademy.dev/pages/proxies-storage/
Example of comparing latest (commit hash 339bafa) storage layout for
Arbitrum_SpokePool(right file) with the latest deployed storage layout (commit hash b41fcee) (left file). You can see that the new state variablemapping fillStatusesis added to the right file while the__gapsize is decremented such that the Arbitrum_SpokePool specific state variablel2GatewayRouterstarts at the same slot 3162