refactor: Rename fillsRefundedIpfsHash -> fillsRefundedHash #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another case of a variable being missed when the naming was changed. The data availability layer isn't bound to IPFS and will probably be something else anyway. This is within the scope of the UMIP, the contracts don't need to be specific about the underlying technology that is used.
nicholaspai
approved these changes
Feb 5, 2024
pxrl
added a commit
that referenced
this pull request
Feb 7, 2024
This is another case of a variable being missed when the naming was changed. The data availability layer isn't bound to IPFS and will probably be something else anyway. This is within the scope of the UMIP, the contracts don't need to be specific about the underlying technology that is used.
pxrl
added a commit
that referenced
this pull request
Feb 8, 2024
This is another case of a variable being missed when the naming was changed. The data availability layer isn't bound to IPFS and will probably be something else anyway. This is within the scope of the UMIP, the contracts don't need to be specific about the underlying technology that is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another case of a variable being missed when the naming was changed. The data availability layer isn't bound to IPFS and will probably be something else anyway. This is within the scope of the UMIP, the contracts don't need to be specific about the underlying technology that is used.