improve: Restore TokensBridged and ExecutedRelayerRefundLeaf event signatures #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnatures Signed-off-by: nicholaspai <npai.nyc@gmail.com>
pxrl
approved these changes
Feb 5, 2024
Contributor
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
LGTM - I verified that caller was the last argument to the event in v2 and that it was not indexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed these event parameters because they were unused but didn't realize this would inadvertently break clients that query these event signatures. Once contracts are updated, clients wouldn't be able to query historical instances of these events, which is required for the
finalizerto to finalize remaining withdrawals from deprecated contract versions.