fix(optimism-spokepool): Need to wrap ETH before distributing any WETH to recipients #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art-contracts-v2 into npai/optimism-spokepool
chrismaree
reviewed
Feb 24, 2022
contracts/SpokePool.sol
Outdated
| bytes32[] memory proof | ||
| ) public nonReentrant { | ||
| // This function potentially is expected to transfer WETH to the recipient so we should wrap all ETH. | ||
| _depositEthToWeth(); |
Member
There was a problem hiding this comment.
does it make sence to only do this if the destinationToken is WETH?
chrismaree
reviewed
Feb 25, 2022
contracts/SpokePool.sol
Outdated
| bytes32[] memory proof | ||
| ) public nonReentrant { | ||
| // This function potentially is expected to transfer WETH to the recipient so we should wrap all ETH. | ||
| _depositEthToWeth(); |
Member
There was a problem hiding this comment.
follow on question: does it make sence to put this in the spoke Pool? would it not make more sence to put this in the Optimism spoke pool only seeing this is only relevant on optimism?
Member
Author
There was a problem hiding this comment.
As discussed IRL i'll move to Optimism_SpokePool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Optimism token bridge sends ETH (address 0xdeaddead...) to SpokePool, so SpokePool accrues an ETH balance after pool rebalances are executed on L1. We make assumptions that the SpokePool has WETH, not ETH, so we need to wrap WETH before distributing refunds or processing relays.
Originally I wanted to implement the wrapping of ETH in the
fallbackorreceivemethods but these are not triggered by ETH deposits over the token bridge because ETH is an ERC20 token on Optimism, so I opted for this approach.