Finish most remaining TODOs #54
Conversation
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
force-pushed
the
remaining_todos
branch
from
898f9f8 to
0d2962c
Compare
| bytes32 slowRelayRoot | ||
| ) public override nonReentrant noActiveRequests { | ||
| // Note: this is to prevent "empty block" style attacks where someone can make empty proposals that are | ||
| // technically valid but not useful. This could also potentially be enforced at the UMIP-level. |
There was a problem hiding this comment.
Do you think there's a situation where we want to publish a new relayer refund root or slow relay root to the SpokePool but we don't want to execute a pool rebalance? In this case, how do we submit an "no-op" pool rebalance root?
There was a problem hiding this comment.
It depends what you mean by "execute a pool rebalance". It's possible in the current design to set up rules where the pool rebalance doesn't actually send tokens until the deficit gets pretty big, so there would be a rebalance leaf, but that leaf wouldn't result in tokens being sent.
| ); | ||
|
|
||
| // Before interacting with a particular chain's adapter, ensure that the adapter is set. | ||
| require(address(crossChainContracts[poolRebalanceLeaf.chainId].adapter) != address(0), "No adapter for chain"); |
There was a problem hiding this comment.
is there any advantage to prevent setting the adapter contract address to 0x0 in the setCrossChainContracts func?
There was a problem hiding this comment.
I think that's a worthwhile check! Will add.
There was a problem hiding this comment.
Actually, I think we should actually allow this to allow a chain to be de-whitelisted.
|
|
||
| // l1 addresses are transformed during l1->l2 calls. See https://developer.offchainlabs.com/docs/l1_l2_messages#address-aliasing for more information. | ||
| // This cannot be pulled directly from Arbitrum contracts because their contracts are not 0.8.X compatible and this operation takes advantage of | ||
| // overflows, whose behavior changed in 0.8.0. |
There was a problem hiding this comment.
add a comment on the unchecked block below
No description provided.