Add origin chain id to whitelisted route mapping #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that duplicate addresses on different chains will not cause issues.
One decision that I made here was to use block.chainid to grab the mainnet chain id rather than having it passed in or something.
This also revealed one bit of weirdness. We were previously assuming in the tests that if origin and destination were whitelisted, this would Just Work™️. However, based on our current structure, mainnet always must have a whitelisted route to any and all L2 tokens for repayments to work since we depend on that mapping to understand which L1 token maps to each L2 token.