improve: Change pool rebalance leaf count type to uint8 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
commented
Mar 2, 2022
contracts/HubPool.sol
Outdated
| // Number of pool rebalance leaves to execute in the poolRebalanceRoot. After this number | ||
| // of leaves are executed, a new root bundle can be proposed | ||
| uint64 unclaimedPoolRebalanceLeafCount; | ||
| uint8 unclaimedPoolRebalanceLeafCount; |
Member
Author
There was a problem hiding this comment.
reordered for style from small to big
mrice32
approved these changes
Mar 2, 2022
contracts/HubPool.sol
Outdated
| uint64 unclaimedPoolRebalanceLeafCount; | ||
| uint8 unclaimedPoolRebalanceLeafCount; | ||
| // When root bundle challenge period passes and this root bundle becomes executable. | ||
| uint64 requestExpirationTimestamp; |
Contributor
There was a problem hiding this comment.
If we change this to a uint32 (which is safe until the year 2106), we should be able to group these variables with proposer and proposerBondRepaid, saving us a storage slot.
Member
Author
There was a problem hiding this comment.
Changed to uint32 and copied and pasted these two vars below proposerBondRepaid. Is that what you had in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max leaf count can only be uint8 to be consistent with size of
RootBundle.claimedBitMapand is the same size passed intoproposeRootBundle, so this is likely just fixing a mistake.